fix(preact): fix umd export for preact #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Use
preact
as the global for the UMD preact bundle instead ofreact
.Why:
The UMD build of preact references a
global.React
:https://unpkg.com/downshift@1.3.0/dist/downshift.preact.umd.js
When targeting preact,
rollup-plugin-alias
changes allreact
module references topreact
:preact
isn't provided as a global to rollup, so for the UMD build, rollup guessesReact
based off of the variable name.Before
After
How:
Declare
preact
as a global instead.Checklist: