Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS build issue #175

Merged
merged 1 commit into from Sep 5, 2017
Merged

Fix TS build issue #175

merged 1 commit into from Sep 5, 2017

Conversation

tansongyang
Copy link
Collaborator

TypeScript tests should not import ChangeOptions, since that property has been removed.

What: Fix TypeScript tests

Why: There was a build issue in #165

How: Remove references to removed ChangeOptions

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

TypeScript tests should not import `ChangeOptions`, since that property has been removed.
@tansongyang tansongyang mentioned this pull request Sep 5, 2017
4 tasks
@kentcdodds kentcdodds merged commit be20364 into downshift-js:master Sep 5, 2017
@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@tansongyang
Copy link
Collaborator Author

@kentcdodds Thanks! I'm honored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants