Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript unused imports #176

Merged
merged 2 commits into from
Sep 5, 2017

Conversation

pbomb
Copy link
Collaborator

@pbomb pbomb commented Sep 5, 2017

What:

  • Fix TypeScript compilation error
  • Fix eslint error with JSDocs

Why:
The Travis CI build is currently broken on these 2 issues.

How:

  • Add tsconfig to error on unused imports to help identify invalid usages and then removed them
  • Added JSDoc @param and @return declarations

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #176   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         267    267           
  Branches       64     64           
=====================================
  Hits          267    267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a1b3e...4033cce. Read the comment docs.

@kentcdodds kentcdodds merged commit 9f0f1a2 into downshift-js:master Sep 5, 2017
@kentcdodds
Copy link
Member

Thank you!

@pbomb
Copy link
Collaborator Author

pbomb commented Sep 5, 2017

You're welcome!

@pbomb pbomb deleted the typescript-unused-imports branch September 5, 2017 14:30
@kentcdodds
Copy link
Member

Thanks again for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@pbomb
Copy link
Collaborator Author

pbomb commented Sep 5, 2017

Cool, thanks! I'll take a look at all those things. Some of these will be new for me.

@kentcdodds
Copy link
Member

You may also find this useful: https://github.com/paypal/downshift/blob/master/other/MAINTAINING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants