Fix React Native onBlur crash #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not really sure how to capture the error in a failing test, but you can see the error getting logged out as the test passes: https://travis-ci.org/paypal/downshift/builds/433607691#L649
I tried using |
|
That's fine. Thanks! |
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Rendez
pushed a commit
to Rendez/downshift
that referenced
this pull request
Sep 30, 2018
* Add failing test for onBlur being called in react native environment * Check for document before trying to access document properties * Add to all contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Check for existence of
this.props.environment.documentbefore trying to access further properties ondocumentWhy:
onBlurwhen called in react native will try to accessthis.props.environment.document.activeElement, andenvironment.documentdoes not exist in React Native, resulting in Downshift crashing RN.How: Added a failing test case to showcase the bug, then added a change that fixes the failing test
Checklist: