[TypeScript] Fixed type for "GetInputPropsOptions" #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the latest `react` types, we should also allow `HTMLTextAreaElement` as part of the props for `GetInputPropsOptions`
|
There seems to be a problem with the build (something wrong with docz it looks like). This can't be released until that build is fixed 😬 |
franklixuefei
added a commit
that referenced
this pull request
Jan 5, 2019
Revert #639 I decided to revert this change for the following reasons: 1. For now, downshift is not designed for textareas, so it doesn't make sense to account for the props that a textarea has in typings, which adds to the complexity of the type definitions. 2. this will no longer work (typescript compiler will throw): ```jsx <input {...getInputProps(...)} /> ``` because the returned type `React.HTMLProps<HTMLInputElement | HTMLTextAreaElement>` cannot be assigned to `React.HTMLProps<HTMLInputElement>`
4 tasks
kentcdodds
pushed a commit
that referenced
this pull request
Jan 5, 2019
…641) Revert #639 I decided to revert this change for the following reasons: 1. For now, downshift is not designed for textareas, so it doesn't make sense to account for the props that a textarea has in typings, which adds to the complexity of the type definitions. 2. this will no longer work (typescript compiler will throw): ```jsx <input {...getInputProps(...)} /> ``` because the returned type `React.HTMLProps<HTMLInputElement | HTMLTextAreaElement>` cannot be assigned to `React.HTMLProps<HTMLInputElement>`
|
🎉 This PR is included in version 3.1.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the latest
reacttypes, we should also allowHTMLTextAreaElementas part of the props forGetInputPropsOptionsWhat:
Typescript type fix.
Why:
to make the type more accurate and prevent broken builds.
How:
I added
HTMLTextAreaElementas part of the props toGetInputPropsOptions, according to the latestreacttype def.Checklist: