Revert "fix(events): stop handled key events propagating (#633)" #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5084cd0.
|
Note that since then, Home and End key events have been added, which also stopPropagation (maybe because the other events did), should that be removed to? |
Yes, let's remove it from there as well. |
|
🎉 This PR is included in version 3.1.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Wooot!!!!! Thanks all!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5084cd0.
What and Why
The changes as part of #633 were incomplete, did not provide a way to allow downshift to handle event and optionally stop propagation, and incorrectly always stopped event propagation on Escape Keydown events.
See discussion in #642 and #643
Whilst we may want to do some stopping of propagation, for now this just reverts that PR so that the events are always propagated.