TypeScript: Add recursive array type to CSS prop #383
Conversation
|
Example of how the current typings would fail:
|
|
@quicksnap Could you rebase (or merge, or whatever to sync with master) this PR? |
quicksnap
force-pushed
the
recursive-css
branch
from
9012bca
to
e8bd2fb
Compare
|
Done. Hopefully all passes now? =) |
|
In order to automate release, should I adjust my commit message or something? |
|
When you click "Squash and merge" you'll see this which allows you to change the commit message of the squashed commit:
|
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 182 182
Branches 52 52
=====================================
Hits 182 182Continue to review full report at Codecov.
|
typings/glamorous-component.d.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import {CSSProperties} from './css-properties' | |||
| import {CSSProperties, CSSPropertiesRecursive} from './css-properties' | |||
There was a problem hiding this comment.
Do we still use CSSProperties in this file?
There was a problem hiding this comment.
Nope; I've removed and updated
What:
Fixes the type definitions for
cssprop. Thecssprop actually accepts either an object or an array of nested objects/arrays.Why:
TypeScript support
How:
Leverage recursive types described in this comment: microsoft/TypeScript#3496 (comment)
Checklist:
The build fails due to previous failure. I have PR #382 that fixes this.