Changing forceReRender to an array #102
Conversation
src/components/PayPalButtons.test.js
Outdated
| @@ -108,7 +108,7 @@ describe("<PayPalButtons />", () => { | |||
| <button onClick={() => setAmount(amount + 1)}> | |||
| Update Amount | |||
| </button> | |||
| <PayPalButtons forceReRender={amount} /> | |||
| <PayPalButtons forceReRender={[amount]} /> | |||
There was a problem hiding this comment.
Thanks @pedroapfilho! This looks great 💯
It would be nice to have this unit test make sure forceRerender works with watching multiple variables. Could you update this to watch another variable? Something like:
<PayPalButtons forceReRender={[amount, currency]} />And then test currency the same way amount is being tested.
There was a problem hiding this comment.
For sure I can! It was lazy from my side to only update these tests, I'll definitely add more!
There was a problem hiding this comment.
Added!
One thing that I couldn't do was to run the project locally. It seems that I have some problems with husky. Do you have any place where you documented what you did on the update? And how you run this project?
There was a problem hiding this comment.
Thanks for adding the additional tests!
One thing that I couldn't do was to run the project locally.
What operating system are you using? I'm on a mac and the following steps should work to get husky working:
rm -rf node_modulesnpm installnpm startornpm run validate
Let me know if that helps.
There was a problem hiding this comment.
I went ahead and merged the PR. The CI failure was just due to the commit message format. I fixed it with the squash and merge option.
Thanks for contributing @pedroapfilho! 💯 🥇 😄
| @@ -100,15 +100,19 @@ describe("<PayPalButtons />", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test("should re-render Buttons when props.forceReRender changes", async () => { | |||
| test("should re-render Buttons when any item from props.forceReRender changes", async () => { | |||
BREAKING CHANGE: forceReRender prop now accepts an array.
Fixes #98
This makes the
forceReRenderan array, so we can add multiple things to theuseEffectinside the component.This enables us to add things like
currency,amount,orderand etc to theforceReRender, so it is always correct at the moment that the user clicks the button to Checkout.This is a breaking change.