fix: typescript type for ScriptReducerAction
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
reviewed
May 15, 2021
src/ScriptContext.tsx
Outdated
| @@ -19,9 +19,11 @@ enum SCRIPT_LOADING_STATE { | |||
| RESOLVED = "resolved", | |||
| } | |||
|
|
|||
| type ScriptLoadingState = `${SCRIPT_LOADING_STATE}`; | |||
There was a problem hiding this comment.
@leogedler I was reading up on enums and I think we should get rid of it and replace it with the following:
Suggested change
| type ScriptLoadingState = `${SCRIPT_LOADING_STATE}`; | |
| const SCRIPT_LOADING_STATE = { | |
| INITIAL: "initial", | |
| PENDING: "pending", | |
| REJECTED: "rejected", | |
| RESOLVED: "resolved", | |
| } as const; | |
| type ScriptLoadingState = typeof SCRIPT_LOADING_STATE[keyof typeof SCRIPT_LOADING_STATE]; |
There was a problem hiding this comment.
@gregjopa got it, make sense the explanation why is better to use a const.
I have pushed the suggested change.
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 94.33% 94.37% +0.03%
==========================================
Files 4 4
Lines 159 160 +1
Branches 56 56
==========================================
+ Hits 150 151 +1
Misses 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScriptLoadingStatetype from the union of the enumSCRIPT_LOADING_STATEand used itas a possible values for
setLoadingStatusto avoid type error when passing a valid string value on the dispatch function.