feat: more robust package publishing #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We add the [`prepack` script][prepack] to take care of building the distribution. This removes the extra `build` command from `./scripts/publish.js` and makes it possible to use this package as a git dependency. * We remove the `dist` folder before packing to avoid including any unnecessary artifacts. * We explicitly generate type declarations with `tsc`. The rollup plugin only generates type declarations if `output.dir` instead of `output.file` is specified. [prepack]: https://docs.npmjs.com/cli/v7/using-npm/scripts
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 4 4
Lines 160 160
Branches 56 56
=======================================
Hits 151 151
Misses 9 9 Continue to review full report at Codecov.
|
gregjopa
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepackscript to take care of building the distribution. This removes the extrabuildcommand from./scripts/publish.jsand makes it possible to use this package as a git dependency.distfolder before packing to avoid including any unnecessary artifacts.tsc. The rollup plugin only generates type declarations ifoutput.dirinstead ofoutput.fileis specified.