-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PayPal hosted fields available as components #160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 98.29% 99.68% +1.38%
==========================================
Files 10 15 +5
Lines 235 316 +81
Branches 70 92 +22
==========================================
+ Hits 231 315 +84
+ Misses 4 1 -3
Continue to review full report at Codecov.
|
import React from "react"; | ||
import type { FC } from "react"; | ||
|
||
import type { PayPalHostedFieldProps } from "../../types/payPalHostedFieldTypes"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Food for thought but we could consider colocating types in the future. I don't want to change this in this particular PR, but in files like this sometimes its nice to have colocation. Anyways just curious if thats a good future refactor and what people think about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is a great suggestion for a future PR. colocation is a great way to organize as this repo grows in the number of files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @borodovisin!
This PR is a first version of the PayPal hosted-fields.
Include two new components to not add much complex in the library.
We have a PayPalHostedFieldsForm component and a PayPalHostedField component
For further info, please check the test cases...