Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing typecheck #408

Merged
merged 2 commits into from Nov 27, 2023
Merged

Fix failing typecheck #408

merged 2 commits into from Nov 27, 2023

Conversation

jshawl
Copy link
Member

@jshawl jshawl commented Nov 27, 2023

This PR updates the components type to match the updated type in paypal-js, from: https://github.com/paypal/paypal-js/pull/420/files#diff-2be14baaff5c425c93291f46a925c3a5bc3e78c438c9d39620bdbc0c154a17f7R5

@jshawl jshawl force-pushed the fix-failing-typecheck branch 3 times, most recently from c4a2007 to de1c7bb Compare November 27, 2023 17:24
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60c68d2) 99.72% compared to head (b95db39) 99.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          18       18           
  Lines         358      361    +3     
  Branches      112      115    +3     
=======================================
+ Hits          357      360    +3     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshawl jshawl marked this pull request as ready for review November 27, 2023 18:40
@jshawl jshawl requested a review from a team as a code owner November 27, 2023 18:40
Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jshawl jshawl merged commit df8f63b into main Nov 27, 2023
3 checks passed
@jshawl jshawl deleted the fix-failing-typecheck branch November 27, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants