This repository has been archived by the owner on May 12, 2020. It is now read-only.
Merge xlevus's changes for allowing mutliple api objects in the same thread #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any other changes required before merging this? |
|
Tests pass and is backwards compatible. Merging. |
avidas
added a commit
that referenced
this pull request
Jan 8, 2014
Merge xlevus's changes for allowing mutliple api objects in the same thread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A consequence of globally setting the client_id and client_secret is that multiple api objects cannot be used on the same thread. This works for a multi-buyer, single-seller scenario but to could be limited for a multi-buyer, multi-seller scenario. For processing payments for multiple accounts in the same thread, we can allow users to pass in their custom api objects without breaking backwards compatibility.