Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

Update aesxor.cc #23

Closed
bryonglodencissp opened this issue Jul 19, 2016 · 1 comment
Closed

Update aesxor.cc #23

bryonglodencissp opened this issue Jul 19, 2016 · 1 comment

Comments

@bryonglodencissp
Copy link

[../seifnode-master/src/aesxor.cc:91]: (error) Shifting 32-bit value by 56 bits is undefined behavior

Found by https://github.com/bryongloden/cppcheck

@aashish-sheshadri
Copy link
Contributor

@bryongloden, Thanks for running cppcheck! The function that the check is complaining about is an internal helper that converts 64bit numbers to bytes. Since its only being used internally, we expect the function to not deal with 32bit numbers. But strictly speaking yes we can make sure that we only process if the iterator is pointing to a int64 value type.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants