Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to pawsey #326

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Porting to pawsey #326

wants to merge 2 commits into from

Conversation

aidanheerdegen
Copy link
Collaborator

@aidanheerdegen aidanheerdegen commented Apr 8, 2022

Wrap ldd in try/except as executables on pawsey seem to be statically linked.
Also for the same reason don't assume LD_LIBRARY_PATH is set.

Commented out call to load_modules. Pawsey has a lot of default modules
that it relies on, so can't reliably monkey with that.

Removed a couple of the bespoke flags Marshall added to the slurm
scheduler, and also explicitly pass through the PAYU environment
variables. Also set in the current environment, but that didn't seem
to make it through to the submitted job.

Closes #323

linked. Also for the same reason don't assume LD_LIBRARY_PATH is set.

Commented out call to load_modules. Pawsey has a lot of default modules
that it relies on, so can't reliably monkey with that.

Removed a couple of the bespoke flags Marshall added to the slurm
scheduler, and also explicitly pass through the PAYU environment
variables. Also set in the current environment, but that didn't seem
to make it through to the submitted job.
@pep8speaks
Copy link

pep8speaks commented Apr 8, 2022

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 106:5: E722 do not use bare 'except'

Line 785:80: E501 line too long (83 > 79 characters)

Line 50:80: E501 line too long (83 > 79 characters)

Comment last updated at 2022-05-26 04:57:08 UTC

@aidanheerdegen aidanheerdegen marked this pull request as draft April 8, 2022 07:14
@aidanheerdegen
Copy link
Collaborator Author

This is a place-holder to make it easier to find and focus attention on what is required to port to magnus @ pawsey. Some of the changes are only to get it working, and aren't intended to be merged into master.

@coveralls
Copy link

coveralls commented Apr 8, 2022

Coverage Status

Coverage decreased (-0.04%) to 42.205% when pulling 68a8a1f on pawsey into 0109f2f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting payu to non-NCI machinery
3 participants