Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metadata schema URL #429

Open
aidanheerdegen opened this issue Mar 18, 2024 · 1 comment
Open

Updated metadata schema URL #429

aidanheerdegen opened this issue Mar 18, 2024 · 1 comment

Comments

@aidanheerdegen
Copy link
Collaborator

The location of the metadata schema is changing

ACCESS-NRI/schema#12

This will require an update to the URL in metadata.py

SCHEMA_URL = "https://raw.githubusercontent.com/ACCESS-NRI/schema/main/experiment_asset.json"

We will need flag that this is being deprecated and when that file is removed it will break existing deployed versions of payu.

Note for the future, if we had used a specific commit then there would be no problem with deleting/moving the file in the schema repo, i.e.

https://raw.githubusercontent.com/ACCESS-NRI/schema/36abe2fe28eb2853a54f41c5eedfd964617d9d68/experiment_asset.json

rather than

https://raw.githubusercontent.com/ACCESS-NRI/schema/main/experiment_asset.json

@aidanheerdegen
Copy link
Collaborator Author

aidanheerdegen commented Apr 5, 2024

Metadata URL was updated in #434 but we should keep this open until we deprecate deployed versions of payu with old URL location.

AFAICT this only affects a single deployed version:

/g/data/vk83/apps/payu/1.1

When we deploy the next version we should add a deprecation notice to the 1.1 version module file and once we have a couple of versions deployed over the top it should be fine to remove that version and the deprecated schema file and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant