-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming to express-openapi-validation #58
Comments
Considering that it's not just Express anymore, probably something along the lines of 'openapi-validation' would be even better :D |
@kobik hey, congratulations on v1.0 but it looks like this issue was missed? |
Thanks a lot @philsturgeon for the PR! We've decided to postpone it to the next major release. In order to pull this out correctly, I believe that the way to rename the package should go like that
|
That’ll do the trick nicely.
|
@kibertoad, @idanto @philsturgeon, going to rename the package to |
Would be amazing! |
Yes please! |
Please review #114
|
Hey, I think the name
express-openapi-validation
would be much more fitting from this project. Since the name change from OpenAPI to Swagger 3 and a bit years ago, the word Swagger is only referring to tools by SmartBear, and it causes a lot of confusion in the community to have folks keep calling everything Swagger when that is no longer the name.Also, it's great that you're using AJV under the hood, but you probably want to protect that implementation detail from your end users allowing you to change the validator in the future.
I'm going to accept the PR for openapi.tools for now (apisyouwonthate/openapi.tools#87), but it would be awesome if you could update the name sometime. :)
The text was updated successfully, but these errors were encountered: