Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IOBUF_SIZE to 64K in decompress_bunzip2.c #6

Closed
chazste opened this issue Jan 3, 2020 · 2 comments
Closed

Change IOBUF_SIZE to 64K in decompress_bunzip2.c #6

chazste opened this issue Jan 3, 2020 · 2 comments
Assignees

Comments

@chazste
Copy link

chazste commented Jan 3, 2020

In testing the resolution to issue #1422 in rufus, I/O performance is significantly worse when writing an image that in BZ compressed versus the straight uncompressed image. It seems that much of the performance loss is due to the [small] I/O buffer size.

Please change IOBUF_SIZE to 64K in decompress_bunzip2.c

@pbatard pbatard self-assigned this Jan 3, 2020
@chazste
Copy link
Author

chazste commented Jan 9, 2020

I've now tested this change on a second workstation (i.e. my "work" workstation, where I regularly do Yocto builds and this is my intended workflow) and am seeing results very similar to writing the uncompressed image.

I agree with your sentiment that if this change is implicated in a later regression it should be backed out. OTOH I don't expect any downside on any machine that is capable of running rufus/windows.

@pbatard
Copy link
Owner

pbatard commented Jan 9, 2020

I will apply this request. But you have to understand that this is not a high priority. So please be patient, okay?

@pbatard pbatard closed this as completed in f6ab2e3 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants