Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't properly patch the file if the hex pairs have mixed length #8

Closed
worproject opened this issue Aug 13, 2020 · 1 comment
Closed

Can't properly patch the file if the hex pairs have mixed length #8

worproject opened this issue Aug 13, 2020 · 1 comment
Assignees
@pbatard

Comments

@worproject
Copy link
Contributor

Here's what happens:

  • If the pairs have the same length (such as ea000037e8630091 ea000036e8630091 0037e8430091e10b 0036e8430091e10b), everything is fine.
  • If the pairs have mixed length (ea000037e8630091 ea000036e8630091 0037e8430091e1 0036e8430091e1), the file gets corrupted.

Applying only the problematic pair is fine:
capt1

but if one more pair of different length is specified, it applies the patch at the wrong offset:
capt2
@pbatard pbatard self-assigned this Aug 13, 2020
@pbatard
Copy link
Owner

pbatard commented Aug 14, 2020

Should be fixed in the new version. Thanks again for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbatard pbatard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbatard