Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(templates): added issue and pr templates #37

Merged
merged 2 commits into from
Jan 23, 2023
Merged

feat(templates): added issue and pr templates #37

merged 2 commits into from
Jan 23, 2023

Conversation

Aadarsh805
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jan 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
gitopener-vercel-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 5:54PM (UTC)

@Aadarsh805
Copy link
Member Author

@sboy99 have a look at the templates when you are free

@sboy99
Copy link
Member

sboy99 commented Jan 22, 2023

Can you provide some references of output, screenshot of a project using this template will be appreciated

@Aadarsh805
Copy link
Member Author

Aadarsh805 commented Jan 22, 2023 •
edited
Loading

Can you provide some references of output, screenshot of a project using this template will be appreciated

yes sigmaTweet, https://github.com/Aadarsh805/SigmaTweet/issues

sboy99
sboy99 requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@sboy99 sboy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the labels need to be renamed, I have mentioned that. If possible add a documentation issue template which adds documentation label by default

.github/ISSUE_TEMPLATE/bug.yml Outdated
name: ​🐞 Bug
description: Report an issue to help us improve the project.
title: "[BUG] <Title>"
labels: ["Goal: fix"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add label "bug / report " as the default, we don't have "Goal: fix" label

.github/ISSUE_TEMPLATE/bug.yml Outdated
@@ -0,0 +1,43 @@
name: ​🐞 Bug
description: Report an issue to help us improve the project.
title: "[BUG] <Title>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change [BUG] <Title> to Bug: <Title>

.github/ISSUE_TEMPLATE/feature_request.yml Outdated
@@ -0,0 +1,28 @@
name: Feature Request 💡
description: Have any new idea or new feature for GitOpener? Please suggest!
title: "[Feature] <description>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change [Feature] to Feat: <Title>

.github/ISSUE_TEMPLATE/feature_request.yml Outdated
name: Feature Request 💡
description: Have any new idea or new feature for GitOpener? Please suggest!
title: "[Feature] <description>"
labels: ["goal: addition"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "goal: addition" to "feat / request"

.github/ISSUE_TEMPLATE/other.yml Outdated
name: Other
description: Use this for any other question or issue. Please do not create blank issues
title: "[OTHER]"
labels: ["status: awaiting triage"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove lebels for other request

.github/pull_request_template.md Show resolved Hide resolved
sboy99
sboy99 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@sboy99 sboy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sboy99 sboy99 merged commit a902987 into main Jan 23, 2023
@sboy99 sboy99 deleted the issue-1 branch January 23, 2023 18:15
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboy99 sboy99 sboy99 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aadarsh805 @sboy99