Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prev/next button #71

Merged
merged 8 commits into from
Feb 12, 2023
Merged

Prev/next button #71

merged 8 commits into from
Feb 12, 2023

Conversation

Aadarsh805
Copy link
Member

Fixes Issue

closes #68

Changes proposed

Added previous and next buttons to the bottom of docs pages for navigating between the docs

Screenshots

image

@vercel
Copy link

vercel bot commented Feb 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
gitopener-vercel-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 11, 2023 at 6:43PM (UTC)

@Aadarsh805
Copy link
Member Author

@sboy99 I made icon files for prev and next icon, but they are not showing for some reason, do check that issue
I'm not sure if I'm using the correct icons

@sboy99
Copy link
Member

sboy99 commented Feb 11, 2023

Fixed the issue of svgs

Copy link
Member

@sboy99 sboy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super logic. really awesome, only few changes. Then we are good to 🚀

@@ -0,0 +1,24 @@
import { ComponentProps } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to keep it. remove it

@@ -0,0 +1,24 @@
import { ComponentProps } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in use, so we should remove it

Copy link
Member

@sboy99 sboy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work 🎉 . LGTM

@sboy99 sboy99 merged commit 06c4d31 into main Feb 12, 2023
@sboy99 sboy99 deleted the prev/next-button branch February 12, 2023 04:16
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add prev and next button in start-contribution docs section
2 participants