Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monospace font customization #59

Closed
elnull opened this issue Feb 6, 2016 · 17 comments
Closed

monospace font customization #59

elnull opened this issue Feb 6, 2016 · 17 comments
Labels
Type: Feature adds functionality

Comments

@elnull
Copy link
Contributor

elnull commented Feb 6, 2016

Is it possible to add an option to customize monospace font?

@pbek
Copy link
Owner

pbek commented Feb 6, 2016

You can select the fonts for the note edit view and the markdown view. What that what you were looking for?

@elnull
Copy link
Contributor Author

elnull commented Feb 6, 2016

I'm looking for possibility to change monospace font face in markdown viewer.
Also it would be helpful that source code in editor will be written with monospace font.

@pbek
Copy link
Owner

pbek commented Feb 6, 2016

I think I fail to understand your question. You can select every font you want in the general settings.

@pbek
Copy link
Owner

pbek commented Feb 6, 2016

Or do you mean to select the font of individual parts of the markdown highlighting?

@elnull
Copy link
Contributor Author

elnull commented Feb 6, 2016

Yes, parts of text wrapped in backtick quotes (`) and blocks of source code are looking better when written with monospace font. Your markdown viewer is using monospace font in that case. So can you add an on option to change font face for that case?

@pbek
Copy link
Owner

pbek commented Feb 6, 2016

I also had such a thing in mind. It's still on my (very long) todo list. 😄
Thank you for your reminder. I will keep it as reference and will notify you in this issue on the progress.

@pbek pbek added Type: Feature adds functionality Help wanted and removed Type: Support labels Feb 6, 2016
@pbek
Copy link
Owner

pbek commented Feb 8, 2016

In v0.95 code in the Markdown edit will now use the Courier font, could you be so kind and report if everything was to your liking when the version is released?

@pbek pbek removed the Help wanted label Feb 8, 2016
@pbek
Copy link
Owner

pbek commented Feb 8, 2016

Version 0.95 is now out.

@elnull
Copy link
Contributor Author

elnull commented Feb 8, 2016

I checked 0.95 and found that editor now use monospace font where it should be. It looks much more comfortable. Thank you. Can you also add an option to change monospace font face?

@pbek
Copy link
Owner

pbek commented Feb 8, 2016

Yes, I have planed that for the future.

@pbek
Copy link
Owner

pbek commented Feb 9, 2016

In the current version 0.96 you can now select a code font and reset each font. Can you please be so kind and report back if it works as intended?

@elnull
Copy link
Contributor Author

elnull commented Feb 9, 2016

It works for me. Thank you for support.

@elnull elnull closed this as completed Feb 9, 2016
@elnull elnull reopened this Feb 9, 2016
@elnull
Copy link
Contributor Author

elnull commented Feb 9, 2016

There is small issue left. New font face applies to editor but viewer still uses only Courier.

@pbek
Copy link
Owner

pbek commented Feb 9, 2016

The viewer has his own fonts and is controlled in a different manner (via CSS Stylesheets). I'll see what I can do.
What country are you from (or what language/s do you speak)? Maybe you want to consider a translation of QOwnNotes. 😉
http://www.qownnotes.org/Knowledge-base/How-can-I-help-to-translate-QOwnNotes

@pbek
Copy link
Owner

pbek commented Feb 14, 2016

Because you did such a great job with the Russian translation and delivered valuable insights I now implemented that the code font in the note Markdown view can be configured in the settings (with the help of some QFont to CSS magic). 😸
It will be shortly released with version 1.0.

Can you please be so kind and report back how it worked out for you.

@elnull
Copy link
Contributor Author

elnull commented Feb 14, 2016

I checked new version. All font customizations are working fine. Thank you for support!

@elnull elnull closed this as completed Feb 14, 2016
@pbek
Copy link
Owner

pbek commented Feb 14, 2016

You are very welcome! Thank you for your translation and your continuous effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature adds functionality
Projects
None yet
Development

No branches or pull requests

2 participants