Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Panel or app #1

Closed
jospoortvliet opened this issue Aug 13, 2015 · 17 comments
Closed

Admin Panel or app #1

jospoortvliet opened this issue Aug 13, 2015 · 17 comments

Comments

@jospoortvliet
Copy link

I think that the settings of this app make sense in the admin panel, especially considering that it is not that big and complicated:
test6
What do you think, @jancborchardt ???

@pbek
Copy link
Owner

pbek commented Aug 13, 2015

I still don't see this screen as settings screen (you can create backups and restore certain tables from a certain backup) but the process is definitely something only an administrator will do.

screenshot61

@jancborchardt
Copy link

This should definitely not be a separate app, but only one section in the admin panel.

It’s similar to the https://github.com/owncloud/updater, which also enables you to make backups.

@pbek
Copy link
Owner

pbek commented Aug 13, 2015

Ok, I'll put it in the admin panel then, thank you for the example.

@jancborchardt
Copy link

Great, thank you! :) And keep in mind to only use one <div id="your-app-id" class=".section"> – not multiple .section elements because then there will be multiple lines. You can use h3 headings for the intermittent headers.

@pbek
Copy link
Owner

pbek commented Aug 13, 2015

Thanks for the advice!

@jancborchardt
Copy link

Sure! Let me know when you’re done and want me to review it. :) Best just post a screenshot.

@pbek
Copy link
Owner

pbek commented Aug 13, 2015

It was quite some work!

screenshot

And I still have the problem with the OwnCloud section showing up two times on the admin page.
Do you have any idea why, @jancborchardt ?

@jancborchardt
Copy link

Nice, looks good!

the OwnCloud section showing up two times on the admin page

I don’t fully understand, can you illustrate what you mean?

@pbek
Copy link
Owner

pbek commented Aug 14, 2015

Thank you!

It got even stranger, it happens not all the time, right now it doesn't on my production system. On several occasions on different system I had the "OwnBackup" admin menu entry (in my screenshot after "File handling" on the left side) showing up a 2nd time, for example after "Cron". (I made the screenshot while removing a line in the code on the dev system, so that it only shows up once, what later caused "OwnBackup" not showing up at all on my production system)
Along with the 2nd menu entry the OwnBackup block was shown a 2nd time on the right too.

@jancborchardt
Copy link

Hm, that’s a more technical issue I can’t help with. :) If it keeps happening and you can reproduce, maybe it’s worth to report a bug to https://github.com/owncloud/core/issues so we solve this for apps.

@pbek
Copy link
Owner

pbek commented Aug 14, 2015

We'll see if anyone reports an issue with ownbackup or if I can reproduce it again.
Thank you for your help and suggestions, @jospoortvliet and @jancborchardt !

@pbek pbek closed this as completed Aug 14, 2015
@jancborchardt
Copy link

Of course, thank you for developing a cool app for ownCloud. :)

@pbek
Copy link
Owner

pbek commented Aug 14, 2015

Not macht erfinderisch. ;)

@jospoortvliet
Copy link
Author

awesome work 💃

@pbek
Copy link
Owner

pbek commented Aug 22, 2015

thanks ;)

@jancborchardt
Copy link

@pbek woah, just saw you’re also the developer of QOwnNotes! Are you coming to the ownCloud Contributor Conference next weekend in Berlin?

@pbek
Copy link
Owner

pbek commented Aug 24, 2015

I'm sorry. Unfortunately there is too much going on for me to make a lovely trip to Berlin! :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants