-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now CreateLocalRepo always returns repo path, even when Default=FALSE #291
Conversation
Good idea, In fact in the beginning repositories were represented as objects. But with time it turns out that they contain only a single string thus the repo was reduced to a single string. However now, when we need to handle URL repos, local repos, Git repos and maybe some more advanced storages in future, it is tempting to add an S4/R5 interface with functions like repo$save() @MarcinKosinski what do you think? Maybe creation of such interface could be a project for students [i.e. within R and Big Data]? |
@pbiecek I think we wrote about S4 classes for repositories here #153 (comment) @adamryczkowski could you please extend NEWS.md file with your change and provide another PR? Thanks for effort :) |
@MarcinKosinski Right, I forgot about it, but it is a great summary for future mappings, thanks for linking it. Tempting idea: submit proposal to R Consortium to build ArchivistHub, large repository of R (and not only) binary objects. This might be a good excuse for new interface for archivist. |
I love R6, and if I were you, I'd consider using this instead of S4 or Reference classes. |
Isn't R6's typeof a S4? By the way, how could we reach R Comsorcium with this idea? Marcin Kosinski Dnia 08.08.2016 o godz. 09:06 Adam Ryczkowski notifications@github.com napisał(a):
|
Need to wait for next call for proposals R6 is different than S4, Dnia 08.08.2016 o godz. 11:40 Marcin Kosiński notifications@github.com napisał(a):
|
archivist.R6 :) ? 2016-08-08 14:02 GMT+02:00 Przemysław Biecek notifications@github.com:
|
Getting back to this PR. Examples worked because they had But our examples has |
All examples fail when
CreateLocalRepo
isn't invoked withdefault=TRUE
parameter, because whendefault=FALSE
the function returns NULL.Why bother with the return value? - Because:
CreateLocalRepo
works very much like object factory, and a lot of people would assume it returns something more complex, than a string.