Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad extract ip from x-forwarded-for #60

Closed
masak64 opened this issue Jun 10, 2022 · 8 comments
Closed

Bad extract ip from x-forwarded-for #60

masak64 opened this issue Jun 10, 2022 · 8 comments

Comments

@masak64
Copy link

masak64 commented Jun 10, 2022

in commit 89d7ff4 change extract last ip from x-forwarded-for, bud client ip is first, spec: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For. For me this broke my app.
@pbojinov
Copy link
Owner

Sorry about that. I'm going to revert this change tonight and push up a new version. Will let you know shortly.

@sidan5
Copy link

sidan5 commented Jun 19, 2022

Breaks my app too.

@ycfreeman
Copy link

same here

@sidan5
Copy link

sidan5 commented Jun 25, 2022

@pbojinov When this is going to be resolved? Thanks!

@aseyfpour
Copy link
Contributor

PR for fixing this issue: #61

@ss-tombrown
Copy link

ss-tombrown commented Jun 28, 2022 •
edited

This breaks our app too!

cc @ss-sarak

@aseyfpour
Copy link
Contributor

Using 2.1.3 version will solve the problem!

@pbojinov
Copy link
Owner

Fixed in version 3.0.1, just pushed it up on npm registry

@YSaxon YSaxon mentioned this issue Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ycfreeman @pbojinov @masak64 @sidan5 @aseyfpour @ss-tombrown