Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 0.81.0 #28

Closed
wants to merge 1 commit into from
Closed

Upgrade rubocop to version 0.81.0 #28

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 2, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.60.0 → ~> 0.81.0) · Repo · Changelog

Release Notes

0.81.0

New features

  • #7299: Add new Lint/RaiseException cop. (@denys281)
  • #7793: Prefer include? over member? in Style/CollectionMethods. (@dmolesUC)
  • #7654: Support with_fixed_indentation option for Layout/ArrayAlignment cop. (@nikitasakov)
  • #7783: Support Ruby 2.7's numbered parameter for Style/RedundantSort. (@koic)
  • #7795: Make Layout/EmptyLineAfterGuardClause aware of case where and or or is used before keyword that break control (e.g. and return). (@koic)
  • #7786: Support Ruby 2.7's pattern match for Layout/ElseAlignment cop. (@koic)
  • #7784: Support Ruby 2.7's numbered parameter for Lint/SafeNavigationChain. (@koic)
  • #7331: Add forbidden option to Style/ModuleFunction cop. (@weh)
  • #7699: Add new Lint/StructNewOverride cop. (@ybiquitous)
  • #7637: Add new Style/TrailingCommaInBlockArgs cop. (@pawptart)
  • #7809: Add auto-correction for Style/EndBlock cop. (@tejasbubane)
  • #7739: Add IgnoreNotImplementedMethods configuration to Lint/UnusedMethodArgument. (@tejasbubane)
  • #7740: Add AllowModifiersOnSymbols configuration to Style/AccessModifierDeclarations. (@tejasbubane)
  • #7812: Add auto-correction for Lint/BooleanSymbol cop. (@tejasbubane)
  • #7823: Add IgnoredMethods configuration in Metrics/AbcSize, Metrics/CyclomaticComplexity, and Metrics/PerceivedComplexity cops. (@drenmi)
  • #7816: Support Ruby 2.7's numbered parameter for Style/Lambda. (@koic)
  • #7829: Fix an error for Style/OneLineConditional when one of the branches contains next keyword. (@koic)

Bug fixes

  • #7236: Mark Style/InverseMethods auto-correct as incompatible with Style/SymbolProc. (@drenmi)
  • #7144: Fix Style/Documentation constant visibility declaration in namespace. (@AdrienSldy)
  • #7779: Fix a false positive for Style/MultilineMethodCallIndentation when using Ruby 2.7's numbered parameter. (@koic)
  • #7733: Fix rubocop-junit-formatter imcompatibility XML for JUnit formatter. (@koic)
  • #7767: Skip array literals in Style/HashTransformValues and Style/HashTransformKeys. (@tejasbubane)
  • #7791: Fix an error on auto-correction for Layout/BlockEndNewline when } of multiline block without processing is not on its own line. (@koic)
  • #7778: Fix a false positive for Layout/EndAlignment when a non-whitespace is used before the end keyword. (@koic)
  • #7806: Fix an error for Lint/ErbNewArguments cop when inspecting ActionView::Template::Handlers::ERB.new. (@koic)
  • #7814: Fix a false positive for Migrate/DepartmentName cop when inspecting an unexpected disabled comment format. (@koic)
  • #7728: Fix an error for Style/OneLineConditional when one of the branches contains a self keyword. (@koic)
  • #7825: Fix crash for Layout/MultilineMethodCallIndentation with key access to hash. (@tejasbubane)
  • #7831: Fix a false positive for Style/HashEachMethods when receiver is implicit. (@koic)

Changes

  • #7797: Allow unicode-display_width dependency version 1.7.0. (@yuritomanek)
  • #7779: Change AllowComments option of Lint/SuppressedException to true by default. (@koic)
  • #7320: Naming/MethodName now flags attr_reader/attr_writer/attr_accessor/attr. (@denys281)
  • #7813: (Breaking) Remove Lint/EndInMethod cop. (@tejasbubane)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 66 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 2, 2020
@depfu depfu bot mentioned this pull request Apr 2, 2020
Closed
@depfu
Copy link
Contributor Author

depfu bot commented Apr 17, 2020

Closed in favor of #29.

@depfu depfu bot closed this Apr 17, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.81.0 branch April 17, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants