Add --pacman-cache, --pacman-log and --maxdepth to CLI options #123
Conversation
atreyasha
force-pushed
the
as/log-cache-maxdepth-cli
branch
from
11e46db
to
c49dfce
Compare
|
Made the respective fixes. Removed the commits for the man-doc to prevent conflicts. I had to keep the changes to the locale since I added translations for new keys. If all is fine, you can merge it. |
atreyasha
force-pushed
the
as/log-cache-maxdepth-cli
branch
2 times, most recently
from
3abd087
to
9e8e31c
Compare
|
Is it okay if I do the merging to master (for both PRs) and fixing of the conflicts directly in master? |
You should be able to,
I don't think anything should need fixing "in master", right? |
|
Ah sorry I worded that wrongly, there should be no conflicts in |
atreyasha
force-pushed
the
as/log-cache-maxdepth-cli
branch
from
9e8e31c
to
56f572a
Compare
…nto command-line options, adding information into shell usage
…lt completions where option requires an argument
atreyasha
force-pushed
the
as/log-cache-maxdepth-cli
branch
2 times, most recently
from
4890f44
to
5bbf7f5
Compare
|
Merging done for both. Just need to rebuild the man-page/changelog which I will leave to you. |
|
And just double-checking, major version bump because we changed how |
|
Yes major version bump sounds right. |
|
🎉 8.0.0 released |
This PR addresses #120 by adding
--pacman-cache,--pacman-logand--maxdepthas CLI options. Commits have been chunked to represent discrete components of this PR.Regarding whether to include
--maxdepthat all, I think it is a good idea to include this parameter to ensure thatfinddoes not get stuck searching some deep user-defined cache directory. The user can add an arbitrarily large value for this if they want to search some basic cache directory for (eg.) AUR packages.