-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscure password #30
Comments
The JupyterLab Credential Store might also be worth considering if it's easy to connect to JupyterLab SQL. |
Ah nice! That looks like a way to protect credentials loaded in notebooks, which is really useful, but a bit different to our use case: the database password is only present in the browser client, so it never leaves the user's computer. It's never stored on the server. The only concern this should address is people looking at the user's screen and copying the password. |
Ah, sorry. I hadn't realised that the connection credentials weren't stored with the notebook. |
Addressed by PR #45 , released in version 0.1.4. |
When the cursor is not explicitly in the connection string box, the password should be obscured. We could bind to the focus / blur events on the input to mediate this.
The text was updated successfully, but these errors were encountered: