Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscure password #30

Closed
pbugnion opened this issue Feb 23, 2019 · 4 comments
Closed

Obscure password #30

pbugnion opened this issue Feb 23, 2019 · 4 comments

Comments

@pbugnion
Copy link
Owner

When the cursor is not explicitly in the connection string box, the password should be obscured. We could bind to the focus / blur events on the input to mediate this.

@martintoreilly
Copy link

The JupyterLab Credential Store might also be worth considering if it's easy to connect to JupyterLab SQL.

@pbugnion
Copy link
Owner Author

pbugnion commented Mar 5, 2019

Ah nice! That looks like a way to protect credentials loaded in notebooks, which is really useful, but a bit different to our use case: the database password is only present in the browser client, so it never leaves the user's computer. It's never stored on the server.

The only concern this should address is people looking at the user's screen and copying the password.

@martintoreilly
Copy link

Ah, sorry. I hadn't realised that the connection credentials weren't stored with the notebook.

@pbugnion
Copy link
Owner Author

pbugnion commented Mar 7, 2019

Addressed by PR #45 , released in version 0.1.4.

@pbugnion pbugnion closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants