Skip to content

Commit

Permalink
Recover coverage and add some missing bits
Browse files Browse the repository at this point in the history
  • Loading branch information
pcarranza committed Sep 21, 2014
1 parent ca09b8e commit 716bb96
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
9 changes: 8 additions & 1 deletion test/test_rb_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,21 @@ def setUp(self):
shell.props.shell_player = player
shell.props.db = db
self.player, self.shell, self.db = player, shell, db
self.db.entry_lookup_by_id.side_effect = lambda x: x
self.db.entry_lookup_by_id.side_effect = lambda x: EntryStub(x)

def test_set_rating_works(self):
rbplayer = RBHandler(self.shell)
self.db.entry_lookup_by_id.side_effect = lambda x: x
rbplayer.set_rating(1, 5)
self.db.entry_set.assert_called_with(1, 'rating', 5)

def test_set_rating_with_invalid_value_fails(self):
rbplayer = RBHandler(self.shell)
with self.assertRaises(Exception):
rbplayer.set_rating(1, 'x')

def test_get_entry_works(self):
rbplayer = RBHandler(self.shell)
entry = rbplayer.get_entry(1)
self.assertEquals(entry.id, 1)

12 changes: 10 additions & 2 deletions test/test_rb_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,23 @@ def test_dequeue_one_works_ok(self):
rb.dequeue(1)
self.shell.props.queue_source.remove_entry.assert_has_calls([
call(1)])

def test_dequeue_many_works_ok(self):
self.shell.props.queue_source.props.query_model = ModelStub(
EntryStub(1), EntryStub(2), EntryStub(3))
rb = RBHandler(self.shell)
rb.dequeue([1, 2])
self.shell.props.queue_source.remove_entry.assert_has_calls([
call(1), call(2)])


def test_clear_play_queue_works_ok(self):
self.shell.props.queue_source.props.query_model = ModelStub(
EntryStub(1), EntryStub(2), EntryStub(3))
rb = RBHandler(self.shell)
rb.clear_play_queue()
self.shell.props.queue_source.remove_entry.assert_has_calls([
call(1), call(2), call(3)])

def test_get_play_queue_works(self):
self.shell.props.queue_source.props.query_model = ModelStub(
EntryStub(1), EntryStub(2), EntryStub(5))
Expand Down

0 comments on commit 716bb96

Please sign in to comment.