Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Add zkSync Mainnet #73

Closed
shelchin2023 opened this issue Jan 18, 2024 · 3 comments
Closed

➕ Add zkSync Mainnet #73

shelchin2023 opened this issue Jan 18, 2024 · 3 comments
Assignees
Labels
new deployment ➕ New deployment request

Comments

@shelchin2023
Copy link
Contributor

Chain Name

zkSync Mainnet

Chain ID

324

RPC URL

https://mainnet.era.zksync.io

Block Explorer URL

https://era.zksync.network/

Deployment Funds

No

@shelchin2023 shelchin2023 added the new deployment ➕ New deployment request label Jan 18, 2024
@pcaversaccio pcaversaccio changed the title [New-Deployment-Request]: ➕ Add zkSync Mainnet Jan 18, 2024
@pcaversaccio
Copy link
Owner

pcaversaccio commented Jan 18, 2024

@shelchin2023 thanks for opening this deployment request. The unfortunate truth with zkSync is that it's not EVM equivalent and we don't plan to deploy on zkSync until their CREATE and CREATE2 opcodes behave the same as on Ethereum (see my thread here on the differences). If we were to deploy CreateX on zkSync, the deployed address would differ, meaning all CreateX deployment addresses would also differ from all other EVM-based network deployments, as well as the view and pure functions that return the computed CREATE and CREATE2 addresses are not correct on zkSync either (I therefore strongly recommend that you not deploy CreateX on zkSync yourself either!). I'm aware that they plan to make it eventually EVM equivalent, but we don't want to waste our deployer nonce on non-future-proof CreateX deployment right now. I will close this issue as "not planned". @mds1 please feel free to re-open if you disagree.

@pcaversaccio pcaversaccio closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@pcaversaccio pcaversaccio pinned this issue Jan 18, 2024
@mds1
Copy link
Collaborator

mds1 commented Jan 18, 2024

Agree with not deploying from the official deployer account for now.

One stopgap is to deploy from another account and provide the addresses for an "unofficial" deploy, like I did with Multicall3, that way users can at least standardize on a canonical deployment for that chain.

image

@pcaversaccio
Copy link
Owner

For anyone who goes that route and deploys CreateX themselves, I would like to highlight that the view and pure functions that return the computed CREATE and CREATE2 addresses are not correct on zkSync! Thus, if you want to deploy CreateX on zkSync, you should rewrite that logic to match zkSync's behaviour. For CREATE2 you can have a look at my Vyper snippet here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new deployment ➕ New deployment request
Projects
None yet
Development

No branches or pull requests

3 participants