Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am making changes to recent clone, trying to add mask support... #23

Open
ghost opened this issue Sep 7, 2021 · 2 comments
Open

I am making changes to recent clone, trying to add mask support... #23

ghost opened this issue Sep 7, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 7, 2021

I added some new options to support unmodified pcb2gcode backend...
Backtrack, invert-gerbers, path-finding-limit and some crude solder mask generation.
I know that the mask generated also mills above the tracks, but tinning these tracks would fix this.
( limitation of the backend?)

These cloned options are handled by the mask creation button
without manually messing with milling --zwork, --invert-gerbers, and --extra-passes options.

image

The problem i am having is in mainwindow.cpp

Added line 159:
connect(ui->maskstartPushButton, SIGNAL(clicked()), this, SLOT(maskstartPcb2gcode()));

at around line 577 i added:
`void MainWindow::maskstartPcb2gcode()
{
QStringList arguments;

args[ MILLARGS ].insert("zwork", ui->maskzworkDoubleSpinBox);
args[ MILLARGS ].insert("invert-gerbers", = true; // <-- how to fix this so it is true without checkbox?
args[ MILLARGS ].insert("extra-passes", ui->maskextrapassesSpinBox);

MainWindow::startPcb2gcode();

}
`
I thought that these args would not get used until the mask start button would get clicked?
but these values override the --zwork --invert-gerbers and --extra-passes from normal milling when starting the program.
( I looked at 'show command line arguments' as well, and it looks like these get clobbered as well )
I am not a wiz when it comes to C++ / QT, but have some small 8051 C experience on some embedded from many years ago.
Can someone here give me pointers on what is going on here?

@the-snowwhite
Copy link
Collaborator

@Efudd-byte

did you mean:

`void MainWindow::maskstartPcb2gcode()

or:

void MainWindow::maskstartPcb2gcode()

@Holotronic
Copy link

Also seems like you have mis mached brackets in your line 159 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant