Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields with invalid pragmas #24

Open
ZLLentz opened this issue Feb 19, 2020 · 4 comments
Open

Fields with invalid pragmas #24

ZLLentz opened this issue Feb 19, 2020 · 4 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Feb 19, 2020

ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SER_RBV.NIST" to "COMERROR_INVALIDPROCESSDATASIZE" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SER_RBV.ELST" to "COMERROR_INVALIDCHANNELNUMBER" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SER_RBV.TTST" to "COMERROR_INVALIDNUMDATABITS" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SER_RBV.FTST" to "COMERROR_INVALIDNUMSTOPBITS" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SEND_RBV.NIST" to "COMERROR_INVALIDPROCESSDATASIZE" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SEND_RBV.ELST" to "COMERROR_INVALIDCHANNELNUMBER" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SEND_RBV.TTST" to "COMERROR_INVALIDNUMDATABITS" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:SEND_RBV.FTST" to "COMERROR_INVALIDNUMSTOPBITS" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:RECV_RBV.NIST" to "COMERROR_INVALIDPROCESSDATASIZE" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:RECV_RBV.ELST" to "COMERROR_INVALIDCHANNELNUMBER" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:RECV_RBV.TTST" to "COMERROR_INVALIDNUMDATABITS" Error (512,512)
ErrorCan't set "IM1L0:XTES:MFW:RAW:ERR:RECV_RBV.FTST" to "COMERROR_INVALIDNUMSTOPBITS" Error (512,512)
@klauer
Copy link
Contributor

klauer commented Feb 19, 2020

We should improve the linting check in ads-ioc to use the dbd file - it can catch these invalid fields.

@ZLLentz
Copy link
Member Author

ZLLentz commented Feb 19, 2020

I'm going to move this issue over to the general lib because that's where the function block lives now. There's nothing weird in the pragma itself, I think it's just on an incompatible type? ComError_t seems to be unhappy to be included in an IOC.

@ZLLentz ZLLentz transferred this issue from pcdshub/lcls-twincat-common-components Feb 19, 2020
@klauer
Copy link
Contributor

klauer commented Feb 19, 2020

I think it's the length is too long for an enum string (16 chars IIRC?)

@ZLLentz
Copy link
Member Author

ZLLentz commented Feb 19, 2020

Got it. Sounds Like I need to either remove these pragmas or create a custom ENUM with shorter names to mirror the values to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants