Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.8.0.4] APU2 Release Date: Thu Jan 1 1970 #117

Closed
Veldkornet opened this issue Sep 5, 2018 · 11 comments
Closed

[4.8.0.4] APU2 Release Date: Thu Jan 1 1970 #117

Veldkornet opened this issue Sep 5, 2018 · 11 comments
Assignees
Labels

Comments

@Veldkornet
Copy link
Contributor

Veldkornet commented Sep 5, 2018

After upgrading from 4.8.0.3 to 4.8.0.4, the BIOS release date does not show the correct date

image

@pietrushnic
Copy link
Member

@Veldkornet thanks for reporting that. We will add this to regression testing and make sure it will never happen again.

@krystian-hebel @miczyg1 FYI

@pietrushnic
Copy link
Member

@Veldkornet what tool you use to display data?

@Veldkornet
Copy link
Contributor Author

Veldkornet commented Sep 5, 2018

It’s just the pfSense gui, which issues the following command:
/bin/kenv -q smbios.bios.reldate
Strangely, if I do this I get the following:

20183108

So it looks like it is set... but I’m not sure if maybe the format changed? Unfortunately I don’t have another system to check.

I can say that pfSense then puts it together as follows:

<?=gettext("Release Date: ");?><strong><?= date("D M j Y ",strtotime($biosdate[0]));?></strong><br/>

See ->
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/widgets/widgets/system_information.widget.php

@krystian-hebel
Copy link
Member

krystian-hebel commented Sep 5, 2018

@Veldkornet are you sure that it showed correct date in 4.8.0.3? We did change the format, but it was between 4.8.0.2 and 4.8.0.3. Now it should be consistent with mainline coreboot for other platforms.

@miczyg1
Copy link
Member

miczyg1 commented Sep 5, 2018

@Veldkornet dmidecode from Debian:

dmidecode -t bios
# dmidecode 3.0
Getting SMBIOS data from sysfs.
SMBIOS 2.7 present.

Handle 0x0000, DMI type 0, 24 bytes
BIOS Information
        Vendor: coreboot
        Version: v4.8.0.4
        Release Date: 20183108
        ROM Size: 8192 kB
        Characteristics:
                PCI is supported
                PC Card (PCMCIA) is supported
                BIOS is upgradeable
                Selectable boot is supported
                ACPI is supported
                Targeted content distribution is supported
        BIOS Revision: 4.0
        Firmware Revision: 0.0

Release date in sign of life is correct too. The GUI must parse the release date differently and seem to get some error.

@pietrushnic
Copy link
Member

@Veldkornet IMO this is a bug. SMBIOS tables should comply to the particular format. We implemented that incorrectly because of assumtion that sign of life will have the same date format as what we have in Release Date in SMBIOS. Many thanks for pointing it out.

release_date

@miczyg1
Copy link
Member

miczyg1 commented Oct 5, 2018

This PR should have fixed the issue: pcengines/coreboot#197

@pietrushnic
Copy link
Member

@miczyg1 please point to release when binaries will be publicly available.

@miczyg1
Copy link
Member

miczyg1 commented Oct 22, 2018

@Veldkornet v4.8.0.5 is released and the bug is fixed. Please have a try: https://pcengines.github.io/#mr-15
We will fix it for legacy release too this month.

@Veldkornet
Copy link
Contributor Author

Looks good

/bin/kenv -q smbios.bios.reldate
10/04/2018

image

@pietrushnic
Copy link
Member

@Veldkornet thank you for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants