Flush before kill on Windows. Add retry on deletion in cluster.remove() #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -209,7 +209,7 @@ def balanced_tokens_across_dcs(self, dcs): | |||
|
|
|||
| def remove(self, node=None): | |||
| if node is not None: | |||
| if not node.name in self.nodes: | |||
| if node.name not in self.nodes: | |||
There was a problem hiding this comment.
Oh boy who had that backwards.
There was a problem hiding this comment.
flake8 for ccm is... not a pretty picture. I figured "leave the place cleaner than when I got here".
There was a problem hiding this comment.
Yeah, I'll flake8 it. I already ran some pep8, and isort.
Reference CASSANDRA-10075: The retry is an attempt to remedy an intermittent failure in dtests where commitlogs cannot be deleted during cluster stop. Flush before kill is an attempt to address a class of problems that has shown up in various dtests while stabilizing Windows tests for 2.2.
|
|
||
| # We want the node to flush its data before shutdown as some tests rely on small writes being present. | ||
| # The default Periodic sync at 10 ms may not have flushed data yet, causing tests to fail. | ||
| if gently is True: |
There was a problem hiding this comment.
Next time, better just to do if gently:
ptnapoleon
added a commit
that referenced
this pull request
Aug 18, 2015
Flush before kill on Windows. Add retry on deletion in cluster.remove()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference CASSANDRA-10075: The retry is an attempt to remedy an intermittent
failure in dtests where commitlogs cannot be deleted during cluster stop.
Flush before kill is an attempt to address a class of problems that has
shown up in various dtests while stabilizing Windows tests for 2.2.