Improve handling when not all loopback addresses are available #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -314,6 +315,15 @@ def start(self, no_wait=False, verbose=False, wait_for_binary_proto=False, | |||
|
|
|||
| common.assert_jdk_valid_for_cassandra_version(self.cassandra_version()) | |||
|
|
|||
| # check whether all loopback aliases are available before starting any nodes | |||
| for node in list(self.nodes.values()): | |||
There was a problem hiding this comment.
I don't think building a list, here or in the line below, is necessary.
|
Other than my little nit about building |
|
@mambocab thanks - I've updated to remove those extra list() and improved the error message a bit; I'll squash after reviews |
| if itf is not None: | ||
| if not common.check_socket_available(itf, return_on_error=True): | ||
| addr, port = itf | ||
| print "Inet address %s:%s is not available; a cluster may already be running or you may need to add the loopback alias" % (addr, port) |
There was a problem hiding this comment.
You will need to from six import print_, and then use the print_ function here, to maintain compatibility across python 2 and 3.
|
+1 after the Python2/3 compat fix. |
On Mac the user needs to make sure the loopback addresses (127.0.0.2, 127.0.0.3, etc.) are created. Currently if they aren't created, ccm fails when creating the cluster, but leaves it in a partial state (usually just the first node is running). This change does a pre-flight check to make sure all loopbacks are available, print a better warning, and exit before starting any nodes.
|
Review comments addressed and commits squashed - should be ready to go |
ptnapoleon
added a commit
that referenced
this pull request
Mar 9, 2016
Improve handling when not all loopback addresses are available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac the user needs to make sure the loopback addresses (127.0.0.2, 127.0.0.3, etc.)
are created. Currently if they aren't created, ccm fails when creating the cluster,
but leaves it in a partial state (usually just the first node is running).
This change does a pre-flight check to make sure all loopbacks are available, print
a better warning, and exit before starting any nodes.