-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback from the CMIP6 example #69
Comments
I will get to them next week. Good suggestions. I hate the color theme as well.... Don't know if I have time to get to them though.... |
Another quick comment; in https://github.com/PCMDI/cmor/blob/master/Test/test_python_CMIP6_experimentID.json#L49, the |
Emma, This test is to make sure that if you have a bad institution, it will be Denis
|
Actually, this test is to make sure that user institutionID is in the CV file. If not you get a critical error with an explanation to the. I need to replace the "???" as contact though. 👍 |
I replaced the "???" character and checked in cmor-master. |
Thank you! Would it be possible to reopen this ticket? The items in my first comment haven't yet been dealt with :) |
Right now, I really really need to work on the CMIP6 Validator for ESGF. Many people are waiting for it. If you would be so inclined to create a pull request for me, I will merge it. Thanks! |
I just tried running the CMIP6 example using CMOR 3.1.1 and it completes without errors :) Thank you for adding the comments to the CMIP6 example! I think the only outstanding item is:
I'm happy to submit a pull request if you think it is worthwhile, otherwise this issue can be closed. Thank you! :) |
@ehogan I think this ticket can be closed, we should open a new one with anything pending. It seems that I deleted the "printf" debugging return value from |
I ran through the CMIP6 example and I have some feedback:
When loading the MIP table, should the line read
table_id = cmor.load_table("CMIP6_Omon.json")
(I was shown a return value when I ran the command in the example)?I had no problems until the
cmor.write
step:The first two traceback messages, i.e.,
and
were printed without the off-white background, so I couldn’t read the dark blue text against the black background of my terminal window.
Just a comment, but when I open the log file with emacs, the background colour causes characters like
^[[2;31;47mC Traceback:
to be visible.The text was updated successfully, but these errors were encountered: