Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible error in cmor documentation #83

Closed
taylor13 opened this issue Jun 5, 2019 · 1 comment · Fixed by #84
Closed

possible error in cmor documentation #83

taylor13 opened this issue Jun 5, 2019 · 1 comment · Fixed by #84

Comments

@taylor13
Copy link

taylor13 commented Jun 5, 2019

A possible problem with the documentation of the "units" argument of the cmor_variable and cmor_time_varying_grid_coordinate functions was raised: The documentation implies that if the unit is a (dimensionless) percentage, the user should pass units="percent", but I think it needs to pass "%". This is being checked and should be confirmed before making any change to the documentation.

@mauzey1
Copy link
Collaborator

mauzey1 commented Jul 2, 2019

@taylor13 "percent" and "%" are interchangeable for udunits2, however CMOR will still treat them as different units since they are different strings. Using "percent" shouldn't effect the unit conversion but the variable's history attribute would show that "percent" was converted to "%". All of the tables use "%" for percentage variables. Should CMOR enforce the use of "%" for percentages?

@mauzey1 mauzey1 transferred this issue from PCMDI/cmor Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants