Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an undo button #40

Closed
maelp opened this issue Feb 19, 2013 · 8 comments
Closed

Add an undo button #40

maelp opened this issue Feb 19, 2013 · 8 comments

Comments

@maelp
Copy link

maelp commented Feb 19, 2013

Sometimes you want to try different stuff and simply undo the last command and try another one, it would be great if there was at least an undo button, and preferably an undo stack!

@pcottle
Copy link
Owner

pcottle commented Feb 20, 2013

Hmmm -- I could implement this by stacking serializations of the repo over time. I can serialize / deserialize any particular state of any commit tree, so every git command could just push a new state onto the stack. Undo would pop one off the stack and load it...

It wouldn't be "pretty" though, in the sense that there wouldn't be any cute animation to get everything back to where it is. I would most likely just fade out the tree and then fade in the un-done version back.

In terms of the UI, it would probably be a command, not a button. Would you be down to do the CSS for the button? I was thinking that the app might need some kind of button bar at the bottom, just to help people get started (like maybe help, undo, reset, and a few others). Thoughts?

@maelp
Copy link
Author

maelp commented Feb 20, 2013

Hello,

a "help, undo, reset" toolbar would be awesome!

I don't have time currently to do the CSS but I might take a look at that this weekend :)

@pcottle
Copy link
Owner

pcottle commented Feb 20, 2013

Hey maelp -- I implemented an undo stack / command this morning, but my Internet was down so I couldn't push the changes. Hopefully it's up tonight and I can update the site

I'll open a separate issue for the command bar at the bottom

@maelp
Copy link
Author

maelp commented Feb 20, 2013

This is great news

Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Wednesday, February 20, 2013 at 18:36 , Peter Cottle wrote:

Hey maelp -- I implemented an undo stack / command this morning, but my Internet was down so I couldn't push the changes. Hopefully it's up tonight and I can update the site
I'll open a separate issue for the command bar at the bottom


Reply to this email directly or view it on GitHub (#40 (comment)).

pcottle added a commit that referenced this issue Feb 21, 2013
@pcottle
Copy link
Owner

pcottle commented Feb 21, 2013

Ok so you can undo in levels, the sandbox, and the level builder now. You can undo all the way back to the original state of the tree (or the last time you hit "reset").

Thanks for the idea!

@pcottle pcottle closed this as completed Feb 21, 2013
@maelp
Copy link
Author

maelp commented Feb 21, 2013

Thanks for taking the time to implement it :)

Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, February 21, 2013 at 04:33 , Peter Cottle wrote:

Ok so you can undo in levels, the sandbox, and the level builder now. You can undo all the way back to the original state of the tree (or the last time you hit "reset").
Thanks for the idea!


Reply to this email directly or view it on GitHub (#40 (comment)).

@pcottle
Copy link
Owner

pcottle commented May 12, 2013

Wow! Looks like people are using it a lot actually:

screen shot 2013-05-12 at 1 16 58 pm

I just added some rough logging to see if people are using the site / actually making progress. I'm going to start the origin project, but your suggestion was great!

@maelp
Copy link
Author

maelp commented May 12, 2013

Glad to see it is really useful, & nice project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants