Allow passing column object to to Proc.
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows mapping arbitrary fields based on the original column name.
|
@stas This is great! Thank you! |
|
@pcreux, thanks for your work on this project! ❤️ |
artur-bobrushko
pushed a commit
to artur-bobrushko/Rails-CSV-importer
that referenced
this pull request
Apr 27, 2019
Introduced in pcreux/csv-importer#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows mapping of arbitrary fields based on the original column name.
See #48
A real-world issue I have to deal with is illustrated in the tests. Basically having a set of fields we want to match to a JSON(B) attribute requires the original column name information.
@pcreux please take a look when you have a chance.
Thanks a lot! 🙇♂️