New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] set default starting tab #55
Conversation
Thanks! I'll take a look ASAP |
Sorry deleted the branch by mistake |
@pd4d10 I figured out issues #57 and #54. They're tied to the same fix. I'll open a pr once you merge this as I have messed up my local repo and fork and both the issue fixes make changes in |
After doing some research, I found that some apps would save the last active tab and use it at the next launch, for example, Apple App Store Personally I think it seems better because users would not be bothered to do an extra setting step. What do you think? |
I see. That makes sense. So I'll modify this. But I still feel the setting to so do should be left as it is too. Or do you want to remove it? |
It makes sense. But it might be more complicated to implement this. We need to have two store keys for each platform, one is for the initiative settings (high priority), the other is for the tab item click (low priority). If the former is present the latter would have no effect. It seems to be a lot of work, so I would recommend not including the settings code in this PR. |
Alright. That makes sense. I'll change it. |
Apologies for taking so much time. There were a few problems that escaped my notice. Within the Hopefully, the gif explains the problem. The problem is only with the Notification screen of github and does not affect other screens of other platforms. Edit: The problem was that |
Fixes #40
I used 4
StorageKeys
, one for each platform. I cannot re-use the same key for all as the count of bottom bar items is not the same. Using the same key would've made this a whole lot easier.Let me know if there are any changes to be made.