Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary search for initial target lookup #18

Open
shish opened this issue Dec 13, 2017 · 4 comments
Open

Use binary search for initial target lookup #18

shish opened this issue Dec 13, 2017 · 4 comments

Comments

@shish
Copy link

shish commented Dec 13, 2017

I just got a 20x speedup in my python translation of this code by doing a binary search instead of "iterate over the whole sorted targets list one at a time until we find our first valid target", I suspect that the PHP version could see benefits too :)

shish/flexihash-py@37f5679

@R-omk
Copy link

R-omk commented Mar 15, 2021

@sylr, could you make a PR with your changes sylr@d44ecc8 to the main repository?

@serima
Copy link
Collaborator

serima commented Mar 16, 2021

looks nice. If you create a pull request, we're ready to accept it.

@ptcong
Copy link

ptcong commented Oct 14, 2021

I've made this pull request #24 @serima

@ptcong
Copy link

ptcong commented May 17, 2022

@serima could you make a release for the last merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants