Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe: Hide Git plugins that exist on .org #11

Open
pdclark opened this issue Jul 26, 2013 · 3 comments
Open

Maybe: Hide Git plugins that exist on .org #11

pdclark opened this issue Jul 26, 2013 · 3 comments

Comments

@pdclark
Copy link
Owner

pdclark commented Jul 26, 2013

No description provided.

@notslang
Copy link

This sounds problematic since people could be hosting forks of plugins on github (or just plugins that happen to have the same name as one on wp.org) that they want to be found. It seems like the fact that we already search for "Plugin URI:" would be enough to exclude plugins that people don't want to be installed via github

@pdclark
Copy link
Owner Author

pdclark commented Dec 30, 2013

I think the idea would be specifically to avoid forks that reference a .org URL.

In what way does searching for Plugin URI already resolve this? I imagine the match would be by URI, not slug.

@notslang
Copy link

Because if someone is releasing their plugin on .org then they probably wouldn't bother making it compatible with https://github.com/afragen/github-updater

Oh, wait... crap. I thought that we were searching for the end of GitHub Plugin URI: so it would make sure that plugins get updates through Github or BitBucket or something. Didn't realize that all plugins have Plugin URI:. Yeah, nevermind - fact that we search for Plugin URI: is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants