Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3: Mismatch with delta 0.0004 on MySpace Dragon Hoard corpus #70

Closed
Shnatsel opened this issue Nov 26, 2021 · 3 comments
Closed

MP3: Mismatch with delta 0.0004 on MySpace Dragon Hoard corpus #70

Shnatsel opened this issue Nov 26, 2021 · 3 comments

Comments

@Shnatsel
Copy link
Contributor

Following the fix for #68, there is a single mismatch above the 0.00002 threshold on the MySpace Dragon Hoard corpus. The max delta is 0.00042961, the file is attached:
std_9dc496596e1558362a28966aacdab41d.mp3.gz

Tested vs ffmpeg version 4.2.4-1ubuntu0.1 built with gcc 9 (Ubuntu 9.3.0-10ubuntu2)

Tested on commit 16497ee

@Shnatsel Shnatsel changed the title Mismatch with delta 0.0004 on MySpace Dragon Hoard corpus MP3: Mismatch with delta 0.0004 on MySpace Dragon Hoard corpus Nov 26, 2021
@pdeljanov
Copy link
Owner

This was an interesting find, because there was a small bug in Symphonia, however the proper fix in my opinion would deviate from both ffmpeg and mpg123. For now I've chosen to just do as they do but print a different message instead.

@Shnatsel
Copy link
Contributor Author

Wow! Thanks for the quick fix!

I'm surprised this was actually actionable 😁

I'll re-run symphonia-check on my other MP3s shortly.

@pdeljanov
Copy link
Owner

No problem. On a side note, I think I actually a bug in ffmpeg regarding this issue. This may cause you to get failures when you test more MP3s.

If you see count1 overrun, malformed bitstream or big_values overrun, malformed bitstream and get a failure, check if it also fails with mpg123. If it doesn't then I think we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants