Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid market don't throws error #11

Closed
imtoori opened this issue Jan 18, 2018 · 2 comments
Closed

Invalid market don't throws error #11

imtoori opened this issue Jan 18, 2018 · 2 comments

Comments

@imtoori
Copy link

imtoori commented Jan 18, 2018

If I check a market using a wrong format the function getlastprice get a nil error, but it should throw an error with something like "market invalid".
An example: btcltc instead of ltcbtc throws no error

@svarogg
Copy link
Contributor

svarogg commented Jan 19, 2018

I think that actually no matter what invalid request you send - there's no error.

Looked at the code, it's actually not checking the result of the request - only that it returned.

Will try to fix the issue and send a PR.

@svarogg
Copy link
Contributor

svarogg commented Jan 26, 2018

I have fixed this issue, but it looks like this repo is not being actively maintained.

If you want, you can try my fork: https://github.com/svarogg/go-binance/

@pdepip pdepip closed this as completed Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants