Avoid variable lengths arrays #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite conforming to C99, variable length arrays are not supported by MSVC, and maybe some other relevant compilers. Therefore we hard-code the maximum required space.
|
Thanks for the ping! That segfault should be fixed now. I'll try to have a look at AppVeyor CI later today or tomorrow. |
|
@cmb69 thanks a lot! And man it would be terrific to have a good Windows CI setup. Thank you very much already! |
|
v1.10.1 is released now with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite conforming to C99, variable length arrays are not supported by
MSVC, and maybe some other relevant compilers. Therefore we hard-code
the maximum required space.
This would solve the Windows PECL build failures. An alternative would be to use do_alloca() and friends (similar to php/php-src@9d31a42), but this appears to be overkill in this case.