New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heightOfFontAtSize bug #2

Closed

2 tasks done

hand-dot opened this issue Jul 25, 2023 · 0 comments

Labels

bug

hand-dot commented Jul 25, 2023

What were you trying to do?

context:

Fix text height rendering for PDF generation pdfme#196 (comment)

where code to fix

pdf-lib/src/core/embedders/CustomFontEmbedder.ts

Line 95 in 9d6c2bf

if (!descender) height -= Math.abs(descent) || 0;

How did you attempt to do it?

none

What actually happened?

none

What did you expect to happen?

none

How can we reproduce the issue?

none

Version

none

What environment are you running pdf-lib in?

Other

Checklist

My report includes a Short, Self Contained, Correct (Compilable) Example.
I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes

none

hand-dot added the bug label

hand-dot changed the title ~~Fix text height rendering for PDF generation~~ heightOfFontAtSize bug

hand-dot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment