Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing-extensions as a runtime dependency #676

Closed
pietermarsman opened this issue Oct 11, 2021 · 0 comments · Fixed by #677
Closed

Add typing-extensions as a runtime dependency #676

pietermarsman opened this issue Oct 11, 2021 · 0 comments · Fixed by #677

Comments

@pietermarsman
Copy link
Member

Bug report

In #661 typing annotations were introduced. For certain functionalities the backport library of typing annotations, typing-extensions, is used. However, this dependency is not installed in the setup.py.

It is installed when the dev extras are installed because it is a dependency of mypy. However, regular users don't install that.

Another issue is that the cicd pipeline did not catch this. Because all of the tests are run with the dev extras installed. Some tests should run without the dev extras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant