Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve aes_string and size deprecation #59

Closed
pdil opened this issue Nov 12, 2022 · 0 comments · Fixed by #61
Closed

Resolve aes_string and size deprecation #59

pdil opened this issue Nov 12, 2022 · 0 comments · Fixed by #61
Assignees
Labels
tech Technical issues and pull requests not directly related to usmap functionality

Comments

@pdil
Copy link
Owner

pdil commented Nov 12, 2022

aes_string

aes_string is soft-deprecated in ggplot2 according to https://ggplot2.tidyverse.org/reference/aes_.html, see warnings below.

══ Warnings ════════════════════════════════════════════════════════════════════
── Warning ('test-plot.R:10'): (code run outside of `test_that()`) ─────────────
Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.Please use `linewidth` instead.
Backtrace:
 1. usmap::plot_usmap("counties", fill = "red")
      at test-plot.R:10:0
 3. ggplot2 (local) `<fn>`(fill = "red", color = "black", size = 0.4, mapping = `<uneval>`)
 4. ggplot2::layer(...)
 5. ggplot2:::deprecate_soft0(...)
── Warning ('test-plot.R:11'): (code run outside of `test_that()`) ─────────────
`aes_string()` was deprecated in ggplot2 3.0.0.Please use tidy evaluation ideoms with `aes()`
Backtrace:
 1. usmap::plot_usmap(data = statepop, values = "pop_2015", color = "blue")
      at test-plot.R:11:0
 2. ggplot2::aes_string(x = "x", y = "y", group = "group", fill = values)
 3. ggplot2:::deprecate_soft0("3.0.0", "aes_string()", details = "Please use tidy evaluation ideoms with `aes()`")

size

size is deprecated in ggplot2 3.4.0 and has been replaced with linewidth

Plan

Fixes will be included in v0.6.1 release.

@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Nov 12, 2022
@pdil pdil self-assigned this Nov 12, 2022
@pdil pdil changed the title Resolve aes_string deprecation Resolve aes_string and size deprecations Nov 12, 2022
@pdil pdil changed the title Resolve aes_string and size deprecations Resolve aes_string and size deprecation Nov 12, 2022
@pdil pdil closed this as completed in #61 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant