Fix global project dependencies (wheels -> wheel) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wheels` is among the minimum dependencies injected for global projects resulting in crashes.
This change corrects the typo to `wheel`.
Below is an example traceback of the error
```
======== Start resolving requirements ========
pip
setuptools
wheels
Adding requirement pip
Adding requirement setuptools
Adding requirement wheels
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/pdm/resolver/core.py", line 23, in _merge_into_criterion
crit = self.state.criteria[name]
KeyError: 'wheels'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/resolvelib/resolvers.py", line 310, in resolve
name, crit = self._merge_into_criterion(r, parent=None)
File "/usr/local/lib/python3.9/site-packages/pdm/resolver/core.py", line 25, in _merge_into_criterion
crit = Criterion.from_requirement(self._p, requirement, parent)
File "/usr/local/lib/python3.9/site-packages/resolvelib/resolvers.py", line 83, in from_requirement
raise RequirementsConflicted(criterion)
resolvelib.resolvers.RequirementsConflicted: Requirements conflict: <NamedRequirement wheels>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/pdm", line 8, in <module>
sys.exit(main())
File "/usr/local/lib/python3.9/site-packages/pdm/core.py", line 71, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/pdm/core.py", line 106, in main
raise err.with_traceback(traceback)
File "/usr/local/lib/python3.9/site-packages/pdm/core.py", line 102, in main
f(options.project, options)
File "/usr/local/lib/python3.9/site-packages/pdm/cli/commands/install.py", line 33, in handle
actions.do_lock(project, strategy="all")
File "/usr/local/lib/python3.9/site-packages/pdm/cli/actions.py", line 61, in do_lock
mapping, dependencies, summaries = resolve(
File "/usr/local/lib/python3.9/site-packages/pdm/resolver/core.py", line 135, in resolve
result = resolver.resolve(requirements)
File "/usr/local/lib/python3.9/site-packages/resolvelib/resolvers.py", line 445, in resolve
state = resolution.resolve(requirements, max_rounds=max_rounds)
File "/usr/local/lib/python3.9/site-packages/resolvelib/resolvers.py", line 312, in resolve
raise ResolutionImpossible(e.criterion.information)
resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=<NamedRequirement wheels>, parent=None)]
```
frostming
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wheelsis among the minimum dependencies injected for global projects resulting in crashes.This change corrects the typo to
wheel.Below is an example traceback of the error
Pull Request Check List
news/describing what is new.Describe what you have changed in this PR.