Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of ResourceWarnings when running the test suite #1915

Merged

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented May 11, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Running the test suite with warnings enabled generates a large number of warnings because of open file descriptors. This PR closes the two offending file handles and also a few others found in the same code files. Two Four warnings remain, one of which is outside this project's control.

@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review May 11, 2023 10:36
Copy link
Sponsor Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (3269dfd) 85.28% compared to head (ab2ec34) 85.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
- Coverage   85.28%   85.27%   -0.01%     
==========================================
  Files          99       99              
  Lines        9151     9155       +4     
  Branches     1987     1990       +3     
==========================================
+ Hits         7804     7807       +3     
- Misses        915      916       +1     
  Partials      432      432              
Flag Coverage Δ
unittests 85.07% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/uninstallers.py 80.51% <50.00%> (-0.32%) ⬇️
src/pdm/installers/installers.py 80.26% <100.00%> (+0.13%) ⬆️
src/pdm/termui.py 90.47% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 0234cff into pdm-project:main May 11, 2023
19 checks passed
@falbrechtskirchinger falbrechtskirchinger deleted the fix-resource-warnings branch May 11, 2023 11:38
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants